Skip to content

Use connection pool for http communications with extension. #6417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Use connection pool for http communications with extension. #6417

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions dd-trace-core/src/main/java/datadog/trace/lambda/LambdaHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import java.io.ByteArrayInputStream;
import java.nio.charset.StandardCharsets;
import java.util.Base64;
import okhttp3.ConnectionPool;
import okhttp3.MediaType;
import okhttp3.OkHttpClient;
import okhttp3.Request;
Expand Down Expand Up @@ -49,6 +50,8 @@ public class LambdaHandler {
private static final String END_INVOCATION = "/lambda/end-invocation";

private static final Long REQUEST_TIMEOUT_IN_S = 1L;
private static final int MAX_IDLE_CONNECTIONS = 5;
private static final Long KEEP_ALIVE_DURATION = 300L;

private static OkHttpClient HTTP_CLIENT =
new OkHttpClient.Builder()
Expand All @@ -57,6 +60,7 @@ public class LambdaHandler {
.writeTimeout(REQUEST_TIMEOUT_IN_S, SECONDS)
.readTimeout(REQUEST_TIMEOUT_IN_S, SECONDS)
.callTimeout(REQUEST_TIMEOUT_IN_S, SECONDS)
.connectionPool(new ConnectionPool(MAX_IDLE_CONNECTIONS, KEEP_ALIVE_DURATION, SECONDS))
Copy link
Contributor Author

@purple4reina purple4reina Jan 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DarcyRaynerDD do you have any opinions on the values we choose here?

.build();

private static final MediaType jsonMediaType = MediaType.parse("application/json");
Expand Down