Skip to content

Conversation

@manuel-alvarez-alvarez
Copy link
Member

What Does This Do

Updates IAST smoke tests to reuse logic in common base class

Motivation

Additional Notes

@manuel-alvarez-alvarez manuel-alvarez-alvarez added tag: no release notes Changes to exclude from release notes comp: asm iast Application Security Management (IAST) labels May 18, 2023
@manuel-alvarez-alvarez manuel-alvarez-alvarez requested a review from a team May 18, 2023 10:51
@manuel-alvarez-alvarez manuel-alvarez-alvarez requested a review from a team as a code owner May 18, 2023 10:51
@pr-commenter
Copy link

pr-commenter bot commented May 18, 2023

Benchmarks

Parameters

Baseline Candidate
commit 1.15.0-SNAPSHOT~40c941b925 1.15.0-SNAPSHOT~6a70c29c92
config baseline candidate
See matching parameters
Baseline Candidate
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 2 performance regressions! Performance is the same for 20 cases.

scenario Δ mean execution_time
scenario:Startup-iast-Telemetry worse
[+0.125ms; +0.317ms] or [+2.213%; +5.606%]
scenario:Startup-waf-Telemetry worse
[+0.120ms; +0.234ms] or [+2.352%; +4.585%]
See unchanged results
scenario Δ mean execution_time
scenario:Startup-base-Agent same
scenario:Startup-base-Agent.start same
scenario:Startup-base-BytebuddyAgent same
scenario:Startup-base-GlobalTracer same
scenario:Startup-base-AppSec same
scenario:Startup-base-Remote Config same
scenario:Startup-base-Telemetry unsure
[+0.049ms; +0.244ms] or [+0.858%; +4.311%]
scenario:Startup-iast-Agent same
scenario:Startup-iast-Agent.start same
scenario:Startup-iast-BytebuddyAgent same
scenario:Startup-iast-GlobalTracer same
scenario:Startup-iast-AppSec same
scenario:Startup-iast-IAST same
scenario:Startup-iast-Remote Config same
scenario:Startup-waf-Agent same
scenario:Startup-waf-Agent.start same
scenario:Startup-waf-BytebuddyAgent same
scenario:Startup-waf-GlobalTracer same
scenario:Startup-waf-AppSec same
scenario:Startup-waf-Remote Config same

@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/iast-improve-smoke-test branch 2 times, most recently from 4ff7db3 to fb8486c Compare May 18, 2023 11:28
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/iast-improve-smoke-test branch from fb8486c to 46502d1 Compare May 18, 2023 14:09
@smola smola added the comp: testing Testing label May 18, 2023
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/iast-improve-smoke-test branch 7 times, most recently from 3915b40 to 0f8fce9 Compare May 23, 2023 17:04
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/iast-improve-smoke-test branch from 0f8fce9 to 6a70c29 Compare May 24, 2023 07:40
@manuel-alvarez-alvarez manuel-alvarez-alvarez merged commit 4bab3c9 into master May 24, 2023
@manuel-alvarez-alvarez manuel-alvarez-alvarez deleted the malvarez/iast-improve-smoke-test branch May 24, 2023 08:24
@github-actions github-actions bot added this to the 1.15.0 milestone May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: asm iast Application Security Management (IAST) comp: testing Testing tag: no release notes Changes to exclude from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants