Skip to content

Conversation

@astuyve
Copy link
Contributor

@astuyve astuyve commented Mar 21, 2023

What does this PR do?

Adopts a patch suggested by @GitMarco, with a slightly renamed method.

Motivation

Backporting a fix to this library for the new Lineage parameter in the xray trace ID
Fixes #89

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Checklist

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@astuyve astuyve requested a review from a team as a code owner March 21, 2023 14:41
Copy link
Contributor

@hghotra hghotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@astuyve astuyve merged commit 503d73c into main Mar 21, 2023
@astuyve astuyve deleted the aj/fix-xray-lineage branch March 21, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Malformed _X_AMZN_TRACE_ID value

5 participants