Fix tags concatenation in custom metric #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@IvanTopolcic please take a look |
IvanTopolcic
approved these changes
Mar 31, 2022
Contributor
IvanTopolcic
left a comment
IvanTopolcic
left a comment
There was a problem hiding this comment.
Looks awesome! Thanks so much for the fix and report, we really appreciate it! I'll go ahead and release a new version of the Java library and I'll close the issue once that's done.
Contributor
Author
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix concatenated tags for custom metrics.
Motivation
A bug that prevents from submitting more than 1 tag.
Bugfix for #75
Testing Guidelines
Unit test and test on a real AWS environment with the custom-built jar.
Types of changes
Checklist