Fix typo in log message #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhinsch
approved these changes
Dec 6, 2021
agocs
approved these changes
Dec 6, 2021
Contributor
agocs
left a comment
agocs
left a comment
There was a problem hiding this comment.
Not sure what's going on with the unit tests, but I'm happy to take a look if you need. Let me know!
Contributor
Author
as discussed offline, let's see if a delay between run() and write() will stop this test from being flaky |
agocs
approved these changes
Dec 6, 2021
Contributor
agocs
left a comment
agocs
left a comment
There was a problem hiding this comment.
That should work just fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix typo