Skip to content

Conversation

@hghotra
Copy link
Contributor

@hghotra hghotra commented Aug 17, 2021

What does this PR do?

Add the functionname attribute to the Lambda span metadata.

Motivation

Look at problem 2 here: https://docs.google.com/document/d/1Jd40XCKibvhVntIiT02xjaZZlq3P2ohRHZ8VnKtu46Q/edit#

Testing Guidelines

Check the trace metadata tags to ensure the functionname attribute is present.

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@hghotra hghotra requested a review from a team as a code owner August 17, 2021 13:27
@hghotra hghotra marked this pull request as draft August 17, 2021 13:36
@hghotra hghotra marked this pull request as ready for review August 20, 2021 16:48
@hghotra hghotra merged commit 8496869 into main Aug 20, 2021
@hghotra hghotra deleted the sls-1260-functionname-attribute branch August 20, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants