Add scripts to publish Java tracer layer. Also add code to set the correct tags in traces #26
Conversation
scripts/list_layers.sh
Outdated
|
|
||
| set -e | ||
|
|
||
| LAYER_NAMES=("Datadog-Python27" "Datadog-Python36" "Datadog-Python37" "Datadog-Python38") |
There was a problem hiding this comment.
Are these the correct layer names?
There was a problem hiding this comment.
👍 deleted the unused line
|
…aDog/datadog-lambda-java into chris.agocs/deploy_java_tracer_layer
agocs
changed the title
|
Added code signing and test-layer-publishing. I'm going to defer on add new regions for now, in the interest of wanting to release this version so that @Hesperide can start testing again |
scripts/list_layers.sh
Outdated
|
|
||
| if [ ${#LAYERS_MISSING_REGIONS[@]} -gt 0 ]; then | ||
| echo "WARNING: Following regions missing layers: ${LAYERS_MISSING_REGIONS[@]}" | ||
| echo "Please run ./add_new_region.sh <new_region> to add layers to the missing regions" |
There was a problem hiding this comment.
You mentioned that you weren't going to add the add_new_region script yet, so I would take this out for now
scripts/list_layers.sh
Outdated
| # Copyright 2019 Datadog, Inc. | ||
|
|
||
| # Lists most recent layers ARNs across regions to STDOUT | ||
| # Optionals args: [layer-name] [region] |
There was a problem hiding this comment.
Optionals -> optional
Also, is layer-name really an arg? It looks like it's hardcoded as dd-trace-java
nhinsch
left a comment
nhinsch
left a comment
There was a problem hiding this comment.
lgtm, just a couple of suggestions
|
I would also reiterate my suggestion of bringing over the add new region script. It's probably not too hard since it's already written, and I suspect we'll need it soon enough, so we might as well get it out of the way now. But everything here looks good. |
scripts/sign_layers.sh
Outdated
|
|
||
| if [ -z "$2" ] | ||
| then | ||
| echo "Usage: ./sign_layers (staging|prod) layer_file.zip" |
scripts/sign_layers.sh
Outdated
| aws s3api delete-object --bucket $S3_BUCKET_NAME --key $S3_SIGNED_ZIP_KEY | ||
|
|
||
| echo | ||
| echo "Successfully signed all layers!" |
There was a problem hiding this comment.
all layers -> the layer (for this repo)
| } | ||
| Span span = GlobalTracer.get().activeSpan(); | ||
| if (span != null) { | ||
| span.setTag("request_id", requestId); |
There was a problem hiding this comment.
I think the other libraries add function_version and resource_names tags as well.
What does this PR do?
This PR adds a script that publishes dd-trace-java as a lambda layer. That will enable customers to add dd-trace-java to their lambdas as a java agent. Additionally, it also sets useful values inside the tracer to make sure the traces get back to Datadog.
Motivation
Testing Guidelines
All manual
Additional Notes
Types of changes
Checklist