feat: eat: Add hierarchical configurable compression levels #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bottlecap/src/config/env.rs
Outdated
| /// | ||
| /// Global level `compression_level` parameter accepts values from 0 (no compression) | ||
| /// to 9 (maximum compression but higher resource usage). Only takes effect if | ||
| /// `use_compression` is set to `true`. |
There was a problem hiding this comment.
Why are we requiring 'use_compression' if the user specifies 'compression_level'?
There was a problem hiding this comment.
Removed this confusing and incorrect comment line.
There was a problem hiding this comment.
This was a config in the (old) Go agent, but now that we have a global compression config this could be removed?
|
Do we have a fast-follow task to update our public docs for this? |
litianningdatadog
force-pushed
the
tianning.li/SVLS-7461
branch
from
1fd4105 to
28aa233
Compare
|
litianningdatadog
force-pushed
the
tianning.li/SVLS-7461
branch
from
9664b89 to
c750e12
Compare
…ig (#788) https://datadoghq.atlassian.net/browse/SVLS-7398 - As part of coming release, bottlecap agent no longer launches Go-based agent when compatibility/AAP/OTLP features are active - Emit the same metric when detecting any of above configuration - Update corresponding unit tests Manifests: - [Test lambda function](https://us-east-1.console.aws.amazon.com/lambda/home?region=us-east-1#/functions/ltn1-fullinstrument-bn-cold-python310-lambda?code=&subtab=envVars&tab=testing) with [logs](https://us-east-1.console.aws.amazon.com/cloudwatch/home?region=us-east-1#logsV2:log-groups/log-group/$252Faws$252Flambda$252Fltn1-fullinstrument-bn-cold-python310-lambda/log-events/2025$252F08$252F21$252F$255B$2524LATEST$255Df3788d359677452dad162488ff15456f$3FfilterPattern$3Dotel) showing compatibility/AAP/OTPL are enabled <img width="2260" height="454" alt="image" src="https://github.com/user-attachments/assets/5dfd4954-5191-4390-83f5-a8eb3bffb9d3" /> - [Logging](https://app.datadoghq.com/logs/livetail?query=functionname%3Altn1-fullinstrument-bn-cold-python310-lambda%20Metric&agg_m=count&agg_m_source=base&agg_t=count&cols=host%2Cservice&fromUser=true&messageDisplay=inline&refresh_mode=paused&storage=driveline&stream_sort=desc&viz=stream&from_ts=1755787655569&to_ts=1755787689060&live=false) <img width="1058" height="911" alt="image" src="https://github.com/user-attachments/assets/629f75d1-e115-4478-afac-ad16d9369fa7" /> - [Metric](https://app.datadoghq.com/screen/integration/aws_lambda_enhanced_metrics?fromUser=false&fullscreen_end_ts=1755788220000&fullscreen_paused=true&fullscreen_refresh_mode=paused&fullscreen_section=overview&fullscreen_start_ts=1755787200000&fullscreen_widget=2&graph-explorer__tile_def=N4IgbglgXiBcIBcD2AHANhAzgkAaEAxgK7ZIC2A%2BhgHYDWmcA2gLr4BOApgI5EfYOxGoTphRJqmDhQBmSNmQCGOeJgIK0CtnhA8ObCHyagAJkoUVMSImwIc4IMhwT6CDfNQWP7utgE8AjNo%2BvvaYRGSwpggKxkgA5gB0kmxgemh8mAkcAB4IHBIQ4gnSChBoSKlswAAkCgDumBQKBARW1Ai41ZxxhdSd0kTUBAi9AL4ABABGvuPAA0Mj4h6OowkKja2DCAAUAJTaCnFx3UpyoeEgo6wgsvJEGgJCN3Jk9wrevH6BV-iWbMqgTbtOAAJgADPg5MY9BRpkZEL4UHZ4LdXhptBBqNDsnAISAoXp7NDVJdmKMfiBsL50nBgOSgA&refresh_mode=sliding&from_ts=1755783890661&to_ts=1755787490661&live=true) <img width="1227" height="1196" alt="image" src="https://github.com/user-attachments/assets/2922eb54-9853-4512-a902-dfa97916b643" />
…d traces - Add global compression_level config parameter (0-9, default: 6) with fallback hierarchy - Support 2-level compression configuration: global level first, then module-specific - This makes configuration more convenient - set once globally or override per module - Apply compression configuration to metrics flushers and trace processor - Add environment variable DD_COMPRESSION_LEVEL for global setting
litianningdatadog
force-pushed
the
tianning.li/SVLS-7461
branch
from
d84d835 to
b8df1ab
Compare
litianningdatadog
force-pushed
the
tianning.li/SVLS-7461
branch
from
b8df1ab to
d161fa8
Compare
…mbda-extension into tianning.li/SVLS-7461
shreyamalpani
approved these changes
Sep 9, 2025
duncanista
reviewed
Sep 9, 2025
| #[serde(deserialize_with = "deserialize_optional_bool_from_anything")] | ||
| pub trace_propagation_http_baggage_enabled: Option<bool>, | ||
|
|
||
| /// @env `DD_METRICS_CONFIG_COMPRESSION_LEVEL` |
There was a problem hiding this comment.
This env var doesn't exist, I cannot see it anywhere in our docs
duncanista
reviewed
Sep 9, 2025
| /// @env `DD_TAGS` | ||
| #[serde(deserialize_with = "deserialize_key_value_pairs")] | ||
| pub tags: HashMap<String, String>, | ||
| /// @env `DD_COMPRESSION_LEVEL` |
There was a problem hiding this comment.
Also couldn't find this in any docs from the Agent, seems like this only exist in the Lambda Forwarder?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add hierarchical configurable compression levels
Test