🐛 [RUM-1863] fix iOS webview detection #2486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/to-staging |
Contributor
|
🚂 Branch Integration: starting soon, merge in < 0s Commit d67128c047 will soon be integrated into staging-44. This build is going to start soon! (estimated merge in less than 0s) you can cancel this operation by commenting your pull request with |
Contributor
|
🚂 Branch Integration: This commit was successfully integrated Commit d67128c047 has been merged into staging-44 in merge commit 1f2722200e. Check out the triggered pipeline on Gitlab 🦊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The fix we introduced in #2440 does not apply in iOS webviews as the user agent don't mention "Safari".
Changes
Adjust
isSafarito also match iOS webviews.Testing
I have gone over the contributing documentation.