Skip to content

Conversation

@DanielNoord
Copy link
Owner

The testutils update is very basic.

I think we would want pyproject.toml support as well, but for now just adding args in an .args file and separating them by spaces is good enough. Just make sure that when we start adding more and more of such files we start considering rewriting them so that we're not stuck with 100+ .args files when we finally get to it.

I have made this optional as I think this might be a bit opinionated and wonder the impact on projects like pylint.

Closes #25

@DanielNoord DanielNoord added the enhancement New feature or request label Jan 8, 2022
@DanielNoord DanielNoord added this to the 0.3.0 milestone Jan 8, 2022
@coveralls
Copy link

coveralls commented Jan 8, 2022

Pull Request Test Coverage Report for Build 1780549797

  • 15 of 15 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 100.0%

Totals Coverage Status
Change from base Build 1780538636: 0.3%
Covered Lines: 302
Relevant Lines: 302

💛 - Coveralls

@DanielNoord
Copy link
Owner Author

Running over pylint gave incorrect changes. Turning this into draft.

@DanielNoord DanielNoord marked this pull request as draft January 8, 2022 16:32
Copy link
Collaborator

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I think we could merge #32 before so it simplify the test.

@DanielNoord DanielNoord merged commit dbb17c2 into main Feb 1, 2022
@DanielNoord DanielNoord deleted the split branch February 1, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Splitting summary and following line

4 participants