Migrate scripts widgets constant to use getter/setter style #1313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myk002
approved these changes
Oct 2, 2024
Member
myk002
left a comment
myk002
left a comment
There was a problem hiding this comment.
approved pending merge of DFHack/dfhack#4972
wiktor-obrebski
force-pushed
the
fix/widgets-constants
branch
from
4f2b3b3 to
d5ab9f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pair PR: DFHack/dfhack#4972
Continuation of DFHack/dfhack#4955, its answer for the comment:
DFHack/dfhack#4955 (comment)
Shortly, its migrate widgets constants to use getter/setter style.