Fix git activity links #2695
Fix git activity links #2695
Conversation
WalkthroughThe changes in the Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
frontend/src/modules/activity/config/display/git/git-activity-link.vue (1)
Line range hint
22-55: Consider adding error handling for malformed URLs.While the URL construction logic is solid, it might benefit from additional error handling:
Consider wrapping the URL construction in a try-catch block to handle potential malformed URLs:
const url = computed(() => { + try { const sourceId = props.activity.sourceParentId ? props.activity.sourceParentId : props.activity.sourceId; const { channel } = props.activity; const urlResource = new URL(channel); const domain = urlResource.hostname; const path = urlResource.pathname; // Rest of the URL construction logic... + } catch (error) { + console.error('Failed to construct git activity URL:', error); + return '#'; // or some fallback URL + } });
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
frontend/src/modules/activity/config/display/git/git-activity-link.vue(1 hunks)
🔇 Additional comments (1)
frontend/src/modules/activity/config/display/git/git-activity-link.vue (1)
22-23: LGTM! The simplified sourceId logic reduces potential null reference issues.
The change to use sourceParentId directly instead of accessing it through the parent object is a good improvement that:
- Reduces the risk of null/undefined errors
- Makes the code more maintainable
- Maintains backward compatibility with the fallback to
sourceId
Let's verify that this change works correctly across different git hosting services:
✅ Verification successful
The sourceParentId change is safe and properly typed
The verification confirms that:
sourceParentIdis properly defined in the Activity interface- The only remaining usage of
parent.sourceIdis in the activities worker service for a different purpose (conversation creation) - The change in git-activity-link.vue aligns with the Activity type definition
- No test files are affected by this change
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Search for all usages of sourceParentId and parent.sourceId
# to ensure the data structure change is consistent across the codebase
# Check for any remaining uses of parent.sourceId that might need updating
rg -l "parent\.sourceId" --type vue --type ts
# Check the activity type definitions to verify sourceParentId is properly typed
rg -l "sourceParentId" --type ts -g "**/types/**"
# Look for any test files that might need updating
rg -l "sourceParentId|parent\.sourceId" --type spec --type test
Length of output: 458
Script:
#!/bin/bash
# Let's try a different approach to search for patterns in Vue files and test files
# Search for parent.sourceId in all files (without type filtering)
rg "parent\.sourceId" -A 2 -B 2
# Search for sourceParentId usage in activity-related files
rg "sourceParentId" -A 2 -B 2 frontend/src/modules/activity
# Check the Activity type definition
cat frontend/src/shared/modules/activity/types/Activity.ts
# Check for any test files related to git activity link
rg -l "git-activity-link" --glob "**/*.spec.*" --glob "**/*.test.*"
Length of output: 4170
Changes proposed ✍️
What
copilot:summary
copilot:poem
Why
How
copilot:walkthrough
Checklist ✅
Feature,Improvement, orBug.Summary by CodeRabbit
New Features
Bug Fixes