Skip to content

Conversation

themarolt
Copy link
Contributor

@themarolt themarolt commented Dec 14, 2023

Changes proposed ✍️

What

🤖[deprecated] Generated by Copilot at c460188

Refactored the deploy-service action to use a single cloud_env input parameter to specify the target environment for deploying the image. Updated various workflows that use the action to pass the appropriate cloud_env value for different services and environments. This simplifies the deployment logic and enables deploying to different clusters and namespaces.

🤖[deprecated] Generated by Copilot at c460188

We're deploying to the clouds of doom
With cloud_env we seal our fate
No matter what the cluster or the namespace
We invoke the deploy-service gate

Why

How

🤖[deprecated] Generated by Copilot at c460188

  • Simplify the input parameters for the deploy-service action by replacing the boolean flags for staging and lfx with a single cloud_env parameter that can take values such as default, prod, lfx_prod, staging, lfx_staging, etc. (link)
  • Update the conditions for deploying the image to the production, lfx production, and staging environments to use the cloud_env parameter instead of the lfx and staging flags. (link, link, link)
  • Add a new step to deploy the image to the lfx staging environment with the corresponding cloud_env value. (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@skwowet skwowet merged commit 005a79e into main Dec 14, 2023
@skwowet skwowet deleted the bugfix/ci-deploy branch December 14, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants