Skip to content

Conversation

@juliaputko
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 97.14286% with 2 lines in your changes missing coverage. Please review.

Project coverage is 46.86%. Comparing base (cce16e6) to head (228e3f9).
Report is 18 commits behind head on smartsim-refactor.

Files with missing lines Patch % Lines
smartsim/_core/utils/helpers.py 85.71% 1 Missing ⚠️
smartsim/entity/application.py 93.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##           smartsim-refactor     #707      +/-   ##
=====================================================
+ Coverage              40.45%   46.86%   +6.40%     
=====================================================
  Files                    110      107       -3     
  Lines                   7326     6512     -814     
=====================================================
+ Hits                    2964     3052      +88     
+ Misses                  4362     3460     -902     
Files with missing lines Coverage Δ
smartsim/builders/ensemble.py 93.04% <100.00%> (ø)
smartsim/experiment.py 87.74% <100.00%> (+6.18%) ⬆️
smartsim/launchable/job.py 96.00% <100.00%> (+5.52%) ⬆️
smartsim/_core/utils/helpers.py 41.43% <85.71%> (+1.25%) ⬆️
smartsim/entity/application.py 82.35% <93.33%> (ø)

... and 8 files with indirect coverage changes

Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small error message nits, and a couple of requests to change where exactly we look for invalid input, but otherwise looks good so far!

@juliaputko juliaputko marked this pull request as ready for review September 18, 2024 21:08
Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of style nits and a few minor suggestions for you to consider while you get the tests passing, but nothing big. Otherwise, this is looking about ready to go on my end!

Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of last minute inconsistencies. Feel free to lmk what you think. Otherwise, looks about ready to go!

Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two last minute nits, but otherwise looks ready to go on my end!

@juliaputko juliaputko merged commit 2cbd3be into CrayLabs:smartsim-refactor Oct 7, 2024
34 of 35 checks passed
@juliaputko juliaputko deleted the valuecheck branch October 7, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants