-
Notifications
You must be signed in to change notification settings - Fork 38
Runtime value checking of public API methods #707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## smartsim-refactor #707 +/- ##
=====================================================
+ Coverage 40.45% 46.86% +6.40%
=====================================================
Files 110 107 -3
Lines 7326 6512 -814
=====================================================
+ Hits 2964 3052 +88
+ Misses 4362 3460 -902
|
MattToast
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small error message nits, and a couple of requests to change where exactly we look for invalid input, but otherwise looks good so far!
MattToast
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of style nits and a few minor suggestions for you to consider while you get the tests passing, but nothing big. Otherwise, this is looking about ready to go on my end!
MattToast
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of last minute inconsistencies. Feel free to lmk what you think. Otherwise, looks about ready to go!
MattToast
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two last minute nits, but otherwise looks ready to go on my end!
No description provided.