Short task to update BatchSettings

[amandarichardsonn]

This PR makes small updates to the existing BatchSettings implementation.

[codecov]

Codecov Report

Attention: Patch coverage is 94.11765% with 2 lines in your changes missing coverage. Please review.

Project coverage is 43.89%. Comparing base (cce16e6) to head (e421b74).
Report is 12 commits behind head on smartsim-refactor.

Files with missing lines	Patch %	Lines
smartsim/settings/arguments/batch_arguments.py	75.00%	1 Missing ⚠️
smartsim/settings/batch_settings.py	93.75%	1 Missing ⚠️

Additional details and impacted files

@@                  Coverage Diff                  @@
##           smartsim-refactor     #704      +/-   ##
=====================================================
+ Coverage              40.45%   43.89%   +3.43%     
=====================================================
  Files                    110      110              
  Lines                   7326     7140     -186     
=====================================================
+ Hits                    2964     3134     +170     
+ Misses                  4362     4006     -356     

Files with missing lines	Coverage Δ
smartsim/entity/application.py	82.60% <100.00%> (ø)
smartsim/entity/ensemble.py	91.30% <100.00%> (-5.84%)	⬇️
smartsim/launchable/job.py	91.11% <100.00%> (+0.63%)	⬆️
smartsim/settings/arguments/launch_arguments.py	100.00% <100.00%> (ø)
smartsim/settings/base_settings.py	100.00% <ø> (ø)
smartsim/settings/batch_command.py	100.00% <100.00%> (ø)
smartsim/settings/launch_command.py	100.00% <ø> (ø)
smartsim/settings/launch_settings.py	94.44% <100.00%> (ø)
smartsim/settings/arguments/batch_arguments.py	74.28% <75.00%> (ø)
smartsim/settings/batch_settings.py	86.27% <93.75%> (ø)

... and 7 files with indirect coverage changes

[mellis13]

Just a couple of comments, but otherwise looks good. Great job on doc strings, btw!

[MattToast]

Two small nits in addition to Matt's comments, but otherwise looks pretty good! Thanks for adding the final touches to these classes for the next stage of the refactor!!

[mellis13]

Thanks for the udpates!

[MattToast]

A couple more small nits, but nothing worth holding approval up over! LGTM!!

[mellis13]

Looks great -- thank you!

[mellis13]

Very small comments, otherwise, LGTM!