Skip to content

Conversation

@AlyssaCote
Copy link
Contributor

In this PR I updated the non snake case filenames to be snake case.

@AlyssaCote AlyssaCote self-assigned this Aug 29, 2024
@codecov
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Please upload report for BASE (mli-feature@8aa990c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
..._core/mli/infrastructure/control/worker_manager.py 0.00% 5 Missing ⚠️
...e/mli/infrastructure/control/request_dispatcher.py 0.00% 3 Missing ⚠️
..._core/mli/infrastructure/control/device_manager.py 0.00% 1 Missing ⚠️
...sim/_core/mli/infrastructure/environment_loader.py 0.00% 1 Missing ⚠️
...mli/infrastructure/storage/dragon_feature_store.py 0.00% 1 Missing ⚠️
smartsim/_core/mli/infrastructure/worker/worker.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             mli-feature     #689   +/-   ##
==============================================
  Coverage               ?   71.34%           
==============================================
  Files                  ?      102           
  Lines                  ?     8525           
  Branches               ?        0           
==============================================
  Hits                   ?     6082           
  Misses                 ?     2443           
  Partials               ?        0           
Files with missing lines Coverage Δ
.../_core/mli/infrastructure/storage/feature_store.py 0.00% <ø> (ø)
..._core/mli/infrastructure/control/device_manager.py 0.00% <0.00%> (ø)
...sim/_core/mli/infrastructure/environment_loader.py 0.00% <0.00%> (ø)
...mli/infrastructure/storage/dragon_feature_store.py 0.00% <0.00%> (ø)
smartsim/_core/mli/infrastructure/worker/worker.py 0.00% <0.00%> (ø)
...e/mli/infrastructure/control/request_dispatcher.py 0.00% <0.00%> (ø)
..._core/mli/infrastructure/control/worker_manager.py 0.00% <0.00%> (ø)

Copy link
Contributor

@mellis13 mellis13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment/question

Copy link
Contributor

@mellis13 mellis13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank_you!

@AlyssaCote AlyssaCote merged commit f6d55d8 into CrayLabs:mli-feature Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants