Refactor exception_handler to avoid unnecessary building and serialization of failure responses.
#687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mli-feature #687 +/- ##
==============================================
Coverage ? 71.34%
==============================================
Files ? 102
Lines ? 8525
Branches ? 0
==============================================
Hits ? 6082
Misses ? 2443
Partials ? 0
|
al-rigazzi
approved these changes
Aug 29, 2024
Collaborator
al-rigazzi
left a comment
al-rigazzi
left a comment
There was a problem hiding this comment.
LGTM, another step towards super-short response times
| reply_channel.send(serialized_resp) | ||
| else: | ||
| logger.warning("Unable to notify client of error without reply_channel") | ||
| logger.warning("Unable to notify client of error without a reply channel") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I fix the
exception_handlerso that it only builds and serializes a failure response if a reply channel is not None. I also needed to tweak the tests a bit by mocking out the reply channels.