Remove pydantic dependency from MLI code #667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mli-feature #667 +/- ##
==============================================
Coverage ? 81.46%
==============================================
Files ? 97
Lines ? 7665
Branches ? 0
==============================================
Hits ? 6244
Misses ? 1421
Partials ? 0
|
mellis13
reviewed
Aug 16, 2024
Contributor
mellis13
left a comment
mellis13
left a comment
There was a problem hiding this comment.
Just one question/comment. Thanks for the update!
|
|
||
|
|
||
| class FeatureStoreKey(BaseModel): | ||
| @dataclass(frozen=True) |
Contributor
There was a problem hiding this comment.
Do we want frozen=True? I'm not familiar with the BaseModel -- is that frozen by default?
If frozen is not used, then I would assume that we need to add setter methods to check that any updates adhere to non-empty string
Contributor
Author
There was a problem hiding this comment.
BaseModels are not frozen by default, but I think we definitely want a frozen dataclass because we don't want FeatureStoreKey instances to be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only used pydantic BaseModels in
FeatureStoreKey, so I converted that into a dataclass and used_post_init_to validate that the key and descriptor are not empty strings. I also made the dataclass frozen.