Skip to content

Conversation

@juliaputko
Copy link
Contributor

No description provided.

@juliaputko juliaputko requested a review from MattToast August 8, 2024 23:34
Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple of sanity checks!!

Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of slightly tighter type hints if you want, and some small style failures in the CI, but otherwise looks about ready on my end!

LGTM!!

@codecov
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 40.51%. Comparing base (cce16e6) to head (8a9cbe2).
Report is 19 commits behind head on smartsim-refactor.

Files with missing lines Patch % Lines
smartsim/_core/dispatch.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##           smartsim-refactor     #662      +/-   ##
=====================================================
+ Coverage              40.45%   40.51%   +0.05%     
=====================================================
  Files                    110      111       +1     
  Lines                   7326     7324       -2     
=====================================================
+ Hits                    2964     2967       +3     
+ Misses                  4362     4357       -5     
Files with missing lines Coverage Δ
smartsim/_core/arguments/shell.py 100.00% <100.00%> (ø)
smartsim/_core/shell/shellLauncher.py 61.70% <100.00%> (+0.83%) ⬆️
smartsim/settings/arguments/launch/local.py 87.50% <100.00%> (ø)
smartsim/settings/arguments/launch/mpi.py 95.34% <100.00%> (ø)
smartsim/settings/arguments/launchArguments.py 100.00% <ø> (+23.07%) ⬆️
smartsim/settings/launchSettings.py 94.20% <ø> (-0.47%) ⬇️
smartsim/_core/dispatch.py 95.83% <0.00%> (-1.01%) ⬇️
---- 🚨 Try these New Features:

@juliaputko juliaputko merged commit a0cc447 into CrayLabs:smartsim-refactor Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants