-
Notifications
You must be signed in to change notification settings - Fork 38
Queue-based Worker Manager #647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AlyssaCote
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! One tiny comment about potentially removing a timing line, but not worth holding up the approval!
mellis13
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic first implementation of the queue-based architecture. Thanks!
This PR adds the
RequestDispatcherto the MLI. TheRequestDispatcherbatches inference requests together.The implementation can be improved, especially by adding:
MemoryPoolcan be wrapped in a SmartSim class and different types of memory can be injected (esp. at unit testing time)RequestDispatcherRequestDispatcher,BatchQueue,DeviceManager, and so on.There is no mechanism to address model versions right now.
We can decide what to do now and what to put up a ticket for.