Skip to content

Conversation

@AlyssaCote
Copy link
Contributor

This PR adds a EnvironmentConfigLoader, which loads and deserializes an SSFeatureStore and an SSQueue from environment variables for the ML Worker Manager.

@AlyssaCote AlyssaCote requested review from al-rigazzi and ankona June 24, 2024 20:57
@AlyssaCote AlyssaCote marked this pull request as draft June 25, 2024 22:48
@AlyssaCote AlyssaCote marked this pull request as ready for review June 26, 2024 16:32
@codecov
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Please upload report for BASE (mli-feature@8a2f173). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...tsim/_core/mli/infrastructure/environmentloader.py 0.00% 20 Missing ⚠️
...e/mli/infrastructure/storage/dragonfeaturestore.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             mli-feature     #621   +/-   ##
==============================================
  Coverage               ?   67.48%           
==============================================
  Files                  ?       96           
  Lines                  ?     6627           
  Branches               ?        0           
==============================================
  Hits                   ?     4472           
  Misses                 ?     2155           
  Partials               ?        0           
Files with missing lines Coverage Δ
...e/mli/infrastructure/storage/dragonfeaturestore.py 0.00% <0.00%> (ø)
...tsim/_core/mli/infrastructure/environmentloader.py 0.00% <0.00%> (ø)

Copy link
Contributor

@ankona ankona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlyssaCote AlyssaCote merged commit 52abd32 into CrayLabs:mli-feature Jul 10, 2024
@al-rigazzi al-rigazzi mentioned this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants