BaseJobGroup, JobGroup, ColocatedJobGroup skeleton #599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amandarichardsonn
changed the title
amandarichardsonn
changed the title
amandarichardsonn
added
ignore-for-release
type: feature
juliaputko
reviewed
Jun 10, 2024
| job_group = ColocatedJobGroup([job_1]) | ||
| assert len(job_group) == 1 | ||
|
|
||
| # compare job names when Job class is up, handleful of other atts, not reused elsewhere |
Contributor
There was a problem hiding this comment.
Can you test these now?
Contributor
Author
There was a problem hiding this comment.
yes nice catch!
tests/temp_tests/test_jobGroup.py
Outdated
| job_group = JobGroup([job_1]) | ||
| assert len(job_group) == 1 | ||
|
|
||
| # cannot test setitem until Job is implemented since there is no comparison bc of the deep copy |
juliaputko
reviewed
Jun 11, 2024
Contributor
juliaputko
left a comment
juliaputko
left a comment
There was a problem hiding this comment.
I think that all looks good!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## smartsim-refactor #599 +/- ##
====================================================
Coverage ? 31.76%
====================================================
Files ? 87
Lines ? 6083
Branches ? 0
====================================================
Hits ? 1932
Misses ? 4151
Partials ? 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.