Skip to content

Conversation

@juliaputko
Copy link
Contributor

No description provided.

Copy link
Contributor

@amandarichardsonn amandarichardsonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 28.36538% with 149 lines in your changes missing coverage. Please review.

Project coverage is 30.72%. Comparing base (7d995bb) to head (861351c).
Report is 55 commits behind head on smartsim-refactor.

Files with missing lines Patch % Lines
smartsim/entity/ensemble.py 19.51% 33 Missing ⚠️
smartsim/entity/model.py 33.33% 20 Missing ⚠️
smartsim/_core/control/controller.py 13.33% 13 Missing ⚠️
smartsim/_core/control/manifest.py 42.10% 11 Missing ⚠️
smartsim/_core/launcher/step/mpiStep.py 35.71% 9 Missing ⚠️
smartsim/experiment.py 0.00% 8 Missing ⚠️
smartsim/_core/control/jobmanager.py 14.28% 6 Missing ⚠️
smartsim/_core/generation/generator.py 45.45% 6 Missing ⚠️
smartsim/settings/base.py 0.00% 6 Missing ⚠️
smartsim/_core/launcher/step/localStep.py 28.57% 5 Missing ⚠️
... and 12 more
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                   @@
##           smartsim-refactor     #579       +/-   ##
======================================================
- Coverage              71.53%   30.72%   -40.81%     
======================================================
  Files                     78       78               
  Lines                   6000     6005        +5     
======================================================
- Hits                    4292     1845     -2447     
- Misses                  1708     4160     +2452     
Files with missing lines Coverage Δ
smartsim/_core/launcher/launcher.py 100.00% <100.00%> (ø)
smartsim/_core/utils/telemetry/util.py 32.35% <ø> (-41.18%) ⬇️
smartsim/database/orchestrator.py 25.86% <ø> (-27.60%) ⬇️
smartsim/entity/__init__.py 100.00% <100.00%> (ø)
smartsim/entity/entity.py 46.66% <ø> (-30.00%) ⬇️
smartsim/entity/files.py 22.58% <ø> (-70.97%) ⬇️
smartsim/error/errors.py 57.44% <ø> (ø)
smartsim/_core/generation/modelwriter.py 22.53% <66.66%> (-69.02%) ⬇️
smartsim/_core/launcher/local/local.py 35.55% <66.66%> (-62.18%) ⬇️
smartsim/_core/utils/helpers.py 30.50% <0.00%> (-59.00%) ⬇️
... and 19 more

... and 20 files with indirect coverage changes

@juliaputko juliaputko merged commit 89214d6 into CrayLabs:smartsim-refactor May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants