Skip to content

fix(#184): --diagnosis-as-error when using --workspace #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2024
Merged

fix(#184): --diagnosis-as-error when using --workspace #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions CodeFormat/src/LuaCheck.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ bool LuaCheck::CheckSingleFile(const FormatContext &context, std::string_view pa

bool LuaCheck::CheckWorkspace(const FormatContext &context) {
auto workspace = context.GetWorkspace();
bool diagnosis = false;
FileFinder finder(workspace);
finder.AddFindExtension(".lua");
finder.AddFindExtension(".lua.txt");
Expand All @@ -136,10 +137,12 @@ bool LuaCheck::CheckWorkspace(const FormatContext &context) {
auto style = context.GetStyle(relativePath);
if (CheckSingleFile(context, relativePath, std::move(opText.value()), style)) {
std::cerr << util::format("Check {} ok.", relativePath) << std::endl;
} else {
diagnosis = true;
}
} else {
std::cerr << util::format("Can not read file {}", relativePath) << std::endl;
}
}
return true;
}
return !diagnosis;
}
Loading