Unpublish External* deps
#2467
Merged
Unpublish External* deps
#2467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
force-pushed
the
unpublish-External-deps
branch
from
1cf1772 to
a34aae5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to 5ab586b. The realisation here is that the imports are only used by exports. No other user of cosmwasm-std than calls of a VM into a contract can use them. This PR does a few small things
make_dependenciestodeps_from_importsto express that the resultingOwnedDepsis implemented through importsdeps_from_importsnon-public because only exports use itExternalApi,ExternalQuerierandExternalStoragewhich are only used bydeps_from_importsand exportsdeps_from_importsto the end of the file againThis then allows us to deactivate all imports and all exports even for target=wasm32-unknown-unknown which later can solve #1962.