Migrate with old hackatom #2437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipshort
reviewed
Mar 24, 2025
webmaster128
force-pushed
the
migrate-with-old-hackatom
branch
from
e36768c to
b0f16ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preparation for #2433. It is a different issues that only popped up during that work.
It makes explicit what we had before too. Only the old style migrate signature was tested in
packages/vm/src/calls.rsbecause the hackatom.was was not recompiled for a long time. In order to ensure a re-compile does not break these tests, we now pin the version of the contract.packages/vm/testdata/hackatom.wasmis a plain copy ofpackages/vm/testdata/hackatom_1.3.wasmfor now in order to avoid breaking all the test of the tests.This makes visible that we lack a test for
call_migrate_with_infowhich actually calls the new migrate function. But we can do that later after recompilinghackatom.wasm.