Add option to generate separate JSON schema files #1478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uint
force-pushed
the
separate-schema-files
branch
from
10bad92 to
c2aceab
Compare
| println!(" --help"); | ||
| println!(" Print this helpfile."); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Souldn't this code live somewhere in the CLI code (close to some main function)? write_api_impl should take the switch as an argument.
I guess the issue is that the contract developer owns the binaries. Maybe we should change that.
There was a problem hiding this comment.
I think it would be super cool if cargo schema was a binary you install with cargo install, but I get the feeling that wouldn't be so easy to do
uint
force-pushed
the
separate-schema-files
branch
from
c2aceab to
c3e1169
Compare
uint
force-pushed
the
separate-schema-files
branch
from
c3e1169 to
afc2a7e
Compare
|
Rebased and applied suggestion from #1476 (comment) |
webmaster128
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1476
I didn't add
clapas a dep here since it felt like overkill, but it can be integrated in the future if these binaries become more complicated.