Rewrite limit_to_pages to avoid storing 2^32 in u32 #1346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ueco-jb
approved these changes
Jul 11, 2022
Contributor
ueco-jb
left a comment
ueco-jb
left a comment
There was a problem hiding this comment.
LGTM
Personally I like this implementation much more, way easier to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves this issue: https://github.com/CosmWasm/cosmwasm/pull/1335/files#r917693865
Before we stored
u32::MAX+1in ausizevariable which is not possible in a 32 bit host. By limiting pages instead of bytes this can be avoided.Also we remove the panic case.