Skip to content

Conversation

@ueco-jb
Copy link
Contributor

@ueco-jb ueco-jb commented Apr 25, 2022

part of #1186

@ueco-jb ueco-jb self-assigned this Apr 25, 2022
@ueco-jb ueco-jb force-pushed the 1186-checked-from-ratio branch from 1c3d584 to 52ffa42 Compare April 25, 2022 14:26
@ueco-jb ueco-jb requested a review from webmaster128 April 25, 2022 14:41
@ueco-jb ueco-jb marked this pull request as ready for review April 25, 2022 14:41
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@webmaster128
Copy link
Member

Could you adapt the PR title? This is one step before checked_from_ratio now

@ueco-jb ueco-jb changed the title Uint64/128/256 - implement checked_from_ratio Uint64/128/256 - implement checked_multiply_ratio Apr 26, 2022
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more suggestion, otherwise 🐎

@ueco-jb ueco-jb merged commit f442125 into main Apr 26, 2022
@ueco-jb ueco-jb deleted the 1186-checked-from-ratio branch April 26, 2022 07:52
@ueco-jb ueco-jb mentioned this pull request Apr 26, 2022
11 tasks
ueco-jb added a commit that referenced this pull request Apr 26, 2022
`Uint64`/`128`/`256` - implement `checked_multiply_ratio`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants