Skip to content

Use the same Sum implementation for all number types #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2022
Merged

Use the same Sum implementation for all number types #1187

merged 1 commit into from
Jan 17, 2022

Conversation

@webmaster128
Copy link
Member

@webmaster128 webmaster128 commented Dec 15, 2021

No description provided.

@webmaster128 webmaster128 requested a review from uint December 15, 2021 10:31
@webmaster128 webmaster128 mentioned this pull request Dec 15, 2021
Closed
11 tasks
uint
uint approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@uint uint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all seem like good changes to me, including the qualified path vs import 👍

@webmaster128 webmaster128 merged commit 9e2b104 into main Jan 17, 2022
@webmaster128 webmaster128 deleted the use-consistent-sum-implementatin branch January 17, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@uint uint uint approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@webmaster128 @uint