Implement opening File Browser from Top Resources #3585
+63
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated to allow the FileBrowserApp to be called from Top Resources with a path. This allows navigation to repositories from Top Resources.
Code updated to listen to current path and update on change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main change is code to remove the query component before passing the URI to FileBrowserApp. This means the path to the repo can be added to settings.ini, under top_resources. Example:
org.phoebus.ui/top_resources= … | file:///path_to_common_folder/Common_PLTs?app=file_browser, Common PLT | …Added a listener to listen to path changes and update the tab name.
Added the function to get the filebrowser icon to display in top resources.
Rebuilt using maven and tested that changes work.
closes #3584
Checklist
Testing:
Documentation: