Skip to content

Conversation

@UrbanBobek
Copy link
Contributor

@UrbanBobek UrbanBobek commented Apr 15, 2025

Add a mechanism to apply a custom zoom factor for the runtime window.

The desired zoom factor can be set in settings.ini as:

org.csstudio.display.builder.runtime.app/default_zoom_factor=1.23

Refers to #3366

Add a mechanism to apply a custom zoom factor for the runtime window.
The desired zoom factor can be set in settings.ini as:
org.csstudio.display.builder.runtime.app/default_zoom_factor=1.23
Copy link
Collaborator

@kasemir kasemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed that the first time around:

Can't the new default_zoom_factor be added to the existing
https://github.com/ControlSystemStudio/phoebus/blob/master/app/display/runtime/src/main/resources/display_runtime_preferences.properties
and associated
https://github.com/ControlSystemStudio/phoebus/blob/master/app/display/runtime/src/main/java/org/csstudio/display/builder/runtime/Preferences.java ?

Seems wrong to start a new preference file for what's just another runtime preference

@UrbanBobek
Copy link
Contributor Author

Sorry, I missed that the first time around:

Can't the new default_zoom_factor be added to the existing https://github.com/ControlSystemStudio/phoebus/blob/master/app/display/runtime/src/main/resources/display_runtime_preferences.properties and associated https://github.com/ControlSystemStudio/phoebus/blob/master/app/display/runtime/src/main/java/org/csstudio/display/builder/runtime/Preferences.java ?

Seems wrong to start a new preference file for what's just another runtime preference

Good point, I didn't consider this during implementation. Fixed.

@kasemir kasemir merged commit fa3fa36 into ControlSystemStudio:master Apr 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants