Skip to content

2466 waveform tweaks #2473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 13, 2018
Merged

2466 waveform tweaks #2473

merged 3 commits into from
Aug 13, 2018

Conversation

@willrogers
Copy link
Contributor

@willrogers willrogers commented Aug 10, 2018

Some minor changes / suggestions:

  • on the waveform view, don't show the Y axis name (always 'Amplitude')
  • on the waveform view, don't show the legend by default - the trace names are on the Y axis
  • on the swt RTPlot, instead of changing the context menu entry from show to hide, use the checkbox by the context menu entry. You can see this in Eclipse if you right-click on the line numbers

cc @skyfrench

@willrogers willrogers requested review from berryma4 and kasemir August 10, 2018 14:05
kasemir added a commit to kasemir/org.csstudio.display.builder that referenced this pull request Aug 13, 2018
@kasemir
Waveform View tweaks
84009ae 
Import of ControlSystemStudio/cs-studio#2473
kasemir
kasemir approved these changes Aug 13, 2018
View reviewed changes
Copy link
Contributor

@kasemir kasemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

kasemir added a commit to ControlSystemStudio/phoebus that referenced this pull request Aug 13, 2018
@kasemir
Waveform viewer tweaks
a9b10e8 
Import of ControlSystemStudio/cs-studio#2473,
but not using CheckMenuItem because it didn't "look" right.
Displays only a check mark, so in non-selected state there's no empty
checkbox. Just "   Show XXX" without an empty checkbox suggests that XXX
should be shown, when in fact the option is _not_ selected

--> Staying with the code that updates label and/or graphics.
@kasemir kasemir merged commit 3e69016 into ControlSystemStudio:master Aug 13, 2018
@willrogers willrogers deleted the 2466-waveform-tweaks branch August 13, 2018 15:55
@kasemir kasemir mentioned this pull request Aug 13, 2018
Merged
@berryma4 berryma4 added this to the 4.6.0 - testing (master) milestone Aug 13, 2018
@willrogers willrogers mentioned this pull request Aug 15, 2018
Merged
@willrogers willrogers mentioned this pull request Oct 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kasemir kasemir kasemir approved these changes

@berryma4 berryma4 Awaiting requested review from berryma4

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.6.0 - testing (master)

Development

Successfully merging this pull request may close these issues.

3 participants

@willrogers @kasemir @berryma4