Opi runtime/view switch #1392
Closed
Opi runtime/view switch #1392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opens opiruntime in editor, the other one opens opiruntime in shell or view.
Contributor
Author
This is already done. The opibuilder-features/org.csstudio.applications.opibuilder.feature from this pull request contains the .view fragment. For anyone who is using that feature, no further actions are required. I realize that the names of the fragment plugins are maybe not the most adequate. I am open to suggestions. |
…udio into OPIRuntime Conflicts: applications/opibuilder/opibuilder-plugins/org.csstudio.opibuilder.rcp/fragment.xml
Contributor
Author
|
Are there any plans to merge this pull request? |
Contributor
Author
|
Due to lack of interest to accept this change, ITER will try to solve this issue by patching the opibuilder. It needs to be done for the beast integration anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1303 and #1333.
I made two fragments: one adds the view/standalone functionality and the other one uses the old opi runtime. You can use one or the other, but not both.
To use it, just add either the org.csstudio.opibuilder.rcp.opiruntime org org.csstudio.opibuilder.rcp.view to your product configuration. I already added the view fragment to the main opibuilder feature, so if your product is feature based, there is nothing you need to do to keep it the old ways.
While this solution works it is not the best design-wise. The OPIView still has to be part of the main plugin and so does the OPIRuntime (there is also RAP...). Ideally, the opibuilder should be redesigned to decouple these kind of things entirely, but that would be a much larger project. Since there is already plan to redo the opibuilder, I don't think it is worth doing it now, but should be kept in mind.