GANIL logbook integration into cs-studio

[shroffk]

The integration can be achieved by using the existing interfaces and by extending the current UI pieces with GNAIL specific details.

The logbook and tag labels should be externalized so they maybe names something else.

[laurentphi]

Ok thanks, I see with Charles Henrie Patard if it can review this for the end of the week in order to discuss the problem during ICALEPCS.
I'm in holliday after ICALEPCS so I will make you a return by October 30th.

Could you please send me your example of tags, properties usage?

Thanks for your help.

PS : It's GANIL not GNAIL.

[charlesHenryPATARD]

Hi Kunal,
Sorry for the delay to answer you. I've just finished the update to the sources 3.2.10 of CSS. Now I can work on the last version of CSS logbook.

Thanks a lot for your patience.
Charles-Henry PATARD

[charlesHenryPATARD]

Hi Kunal,
Have you got a complete example of CSS logbook ? I would like to explore all abilities of your development.
Thanks a lot.

[shroffk]

Hi,
There are a few examples you could look at
org.csstudio.logbook.olog
org.csstudio.logbook.sns

[charlesHenryPATARD]

Hi,
Thanks a lot.

---

De : Kunal Shroff [notifications@github.com]
Date d'envoi : jeudi 31 octobre 2013 16:07
À : ControlSystemStudio/cs-studio
Cc: Patard Charles-Henri
Objet : Re: [cs-studio] GANIL logbook integration into cs-studio (#143)

Hi,
There are a few examples you could look at
org.csstudio.logbook.olog
org.csstudio.logbook.sns

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/143#issuecomment-27493561.

[kasemir]

Hi:

The SNS example is mostly for submitting entries. It should be OK for
creating entries from the context menus of BOY, Data Browser, Alarm GUI.
One quick that we haven't fully solved: The SNS logbook entries have
"title" and "text". The OLog only has "text". So how do I get a "title",
how can users enter it? For now we treat the first line of the "text" as a
title, with some hacking:
Short title -> entry will use that for both the SNS entry title and text
Title\nText -> Complete SNS entry with title and text
Very long title\nText -> Title is too long for valid SNS entry. Create
entry with shortened title, wrap rest of title into the text, followed by
actual text.

That "works", but our users currently need to learn that the 1st line of
the text will become the title. Nothing in the GUI will indicate it.

The readout somewhat works for the SNS logbook, but may have problems,
since it's not really used at this time.

Thanks,
Kay

There are a few examples you could look at

org.csstudio.logbook.olog
org.csstudio.logbook.sns

[charlesHenryPATARD]

Hi All,
I apologize for answering so late. My work on LogBook was not the priority of my boss. So, I explored the new fonctionalities of csstudio logbook plugins.

Can you explain the reason why the attachements for opi are saved in /tmp/opi....png and not for data browser plot ?
I need to add the screenshot in our logbook and the way to put the attachment is different between BOY and Data Browser.

Thanks.

[kasemir]

There may be historical reasons, because once upon a time an "attachment" had to be a file?

With the new logbook API, the attachment is just a stream. So ideally, no file is required. The attachment (plot, screenshot, ..) is just an image in memory, submitted via a ByteArrayInputStream. The logbook API still requires a (file)name, but you can make that up, ending in "..png" to identify the format, but without an actual file.
One difference between Data Brower and BOY: The data browser plot can easily be "drawn" into an off-screen image buffer. For the BOY display, simply drawing the display into an image buffer doesn't work because some of the widgets may be SWT widgets. So this requires taking a screenshot. I think they could still both be drawn resp. captured into a memory buffer image, shouldn't require a file.

[charlesHenryPATARD]

Hello,
My work on integration of J5 Log book is completed. GANIL would like to express some wishes.

The first one is : When creating an logbook entry from BOY editor, the automatic screen shot don't show the whole editor window (by right click on BOY editor). As you can see below

Is it possible to take a whole automatic screen shot ?

The second one is : We don't use the fields LogBooks and Tags. Is it possible to add one or two preferences which can hide those two fields ? We can do that for fields Login and Password.

If you're agree by the two proposals, I'd be glad to do that.

Finally, a nullPointerException was created by clicking on ScreenShot or CSS Window button. I've found the reason why. It was due to a return null; of getScreenShot() method in class org.csstudio.utility.singlesource.UIHelper.java.
The source code missing is :

public Image getScreenshot(
            final Display display,
            final Drawable drawable,
            final Rectangle bounds) {

        final GC gc = new GC(drawable);
        final Image image = new Image(display, bounds);
        gc.copyArea(image, 0, 0);
        gc.dispose();

        return image;
    }

The source version for this work is CSS 3.2.10. The version 3.2.9 is correct. Maybe this error was corrected in last versions of CSS sources ?

Best regards.

[shroffk]

Hello,

Congrats on the integration

While I like the idea of somehow forcing the window to resize to the maximum before taking a cs-studio screenshot I am not sure how to achieve this.
What should happens if the window cannot be re-sized any more than its current size?
What if I only want to capture what being shown in the window and not everything else?

Do you have a list of attributes/labels that you normally attache to a log entry?

I think the getScreenshot() functionality was moved into the RAP/RCPUIHelper, if you include the org.csstudio.utility.singlesource.rcp plugin into your product you shouldn't see this error.

[kasemir]

On Tue, Apr 15, 2014 at 11:58 AM, charlesHenryPATARD <
notifications@github.com> wrote:

Is it possible to take a whole automatic screen shot ?

I think XIhui once explained a techincal issue with this:
The Data Browser can create a screenshot by "painting" the current plot
into an image instead of painting to the screen.
BOY, however, cannot simply paint an *.opi into an off-screen image. It
could do that for the draw2d-based widgets, but not for the native SWT
widgets. So to get a screenshot, BOY actually needs to do a screen capture,
and that means you get the scrollbars, or the partial display if only a
section is actually visible on the screen.
If you can figure out how to paint the SWT widgets into an off-screen image
buffer, you could paint the whole *.opi display into an image and that
would solve your problem.

-Kay

[kasemir]

I think Kunal is correct on the single-source helper.
You need to include either the RCP or the RAP implementation.

On Tue, Apr 15, 2014 at 11:00 PM, Kay Kasemir kay.kasemir@gmail.com wrote:

On Tue, Apr 15, 2014 at 11:58 AM, charlesHenryPATARD <
notifications@github.com> wrote:

Is it possible to take a whole automatic screen shot ?

I think XIhui once explained a techincal issue with this:
The Data Browser can create a screenshot by "painting" the current plot
into an image instead of painting to the screen.
BOY, however, cannot simply paint an *.opi into an off-screen image. It
could do that for the draw2d-based widgets, but not for the native SWT
widgets. So to get a screenshot, BOY actually needs to do a screen capture,
and that means you get the scrollbars, or the partial display if only a
section is actually visible on the screen.
If you can figure out how to paint the SWT widgets into an off-screen
image buffer, you could paint the whole *.opi display into an image and
that would solve your problem.

-Kay

[charlesHenryPATARD]

Hello,
Kay and Kunal thank you for your answers. I included org.csstudio.utility.singlesource.rcp to my product and it works fine.
Furthermore, I understand the technical constraints of achievement screen-shot for boy editor.

Kunal in your last post you asked me the list of attributes/labels. Our needs of attributes on LogBook view are really minimalist. The only attributes we need are Level and text field. These attributes already exists.
For the rest, the other attributes are automatically set (password, login, Logbooks and Tags). It's the reason why I would like to know if preference(s) can be added for hide Logbooks and/or Tags attributes. We can do the same for Login and Password with org.csstudio.logbook.ui/Autenticate.user preference.

Best regards