Skip to content

Dockerfile: freeze our dependencies #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2022
Merged

Dockerfile: freeze our dependencies #318

merged 1 commit into from
Mar 21, 2022

Conversation

@Mstrodl
Copy link
Member

@Mstrodl Mstrodl commented Mar 21, 2022

:(

@Mstrodl Mstrodl force-pushed the hotfix/mstrodl/freeze branch from e639d38 to 3ef9483 Compare March 21, 2022 19:11
devinmatte
devinmatte approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@devinmatte devinmatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better. I would avoid using pip freeze as it can lead to dumping unused deps into the install process of the repo, but, this is a good stopgap

@Mstrodl Mstrodl force-pushed the hotfix/mstrodl/freeze branch from 3ef9483 to 3c23224 Compare March 21, 2022 19:55
@Mstrodl Mstrodl merged commit 6c8dc4a into ComputerScienceHouse:develop Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devinmatte devinmatte devinmatte approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Mstrodl @devinmatte