Skip to content

Pylint Fixes #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2021
Merged

Pylint Fixes #285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f7ad70
Ignore abstract-class-instantiated for sentry init
mxmeinhold Aug 17, 2021
fe708ca
Add `packet/routes` to pylint in ci
mxmeinhold Aug 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/python-app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
- name: Lint with pylint
run: |
pylint packet
pylint packet/routes packet

typecheck:
runs-on: ubuntu-latest
Expand Down
1 change: 1 addition & 0 deletions packet/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@
app.logger.info('OIDCAuth configured')

# Sentry
# pylint: disable=abstract-class-instantiated
sentry_sdk.init(
dsn=app.config['SENTRY_DSN'],
integrations=[FlaskIntegration(), SqlalchemyIntegration()]
Expand Down
4 changes: 2 additions & 2 deletions packet/routes/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,8 +210,8 @@ def upperclassman_stats(uid):

@app.route('/readiness')
def readiness() -> tuple[str, int]:
'''A basic healthcheck. Returns 200 to indicate flask is running'''
return "ready", 200
"""A basic healthcheck. Returns 200 to indicate flask is running"""
return 'ready', 200


def commit_sig(packet, was_100, uid):
Expand Down