Hide sigs from frosh and sort by names by default #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galenguyer
approved these changes
Aug 16, 2021
Collaborator
Author
|
Small regression: in active packets list, for onfloors, the row background for where the sign button would be is not the right color. |
Collaborator
Author
|
Linting should be fixed by #285 |
Collaborator
Author
Screenshots!
|
Member
|
Rebasing to pull in pylint fixes, then will squash before merging. |
Collaborator
Author
|
I don't think i'm going to get to fixing that regression today. Any objection to me just merging? Regression doesn't actually hinder signing a packet, you just have to click into the packet. |
Member
|
LG(Enough)TM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@crigney3 please review
Still need to test things on dev, but this is the preliminary so I can toss it on OKD