Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,16 @@
language: python
python:
- "3.7"
services:
- "docker"

install:
- "pip install -r requirements.txt"
- "curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.35.3/install.sh | bash"
- "nvm install"
- "nvm use"
- "npm install -g gulp"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a naive approach to handling gulp. In reality we should have an npm script that runs lint. Not an issue that needs to be fixed, but should be going forward

- "npm install"
script:
- "pylint --load-plugins pylint_quotes packet/routes packet"
- "gulp lint"
- "docker build -t packet ."
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ fail blocking you from merging. To make your life easier just run it before maki

To run pylint use this command:
```bash
pylint packet
pylint --load-plugins pylint_quotes packet/routes packet
```

All python files should have a top-level docstring explaining the contents of the file and complex functions should
Expand Down
3 changes: 2 additions & 1 deletion gulpfile.js/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,5 @@ requireDir('./tasks', {recurse: true});

// Default task
gulp.task('default', gulp.parallel('css', 'js'));
gulp.task('production', gulp.parallel('css', 'js', 'generate-favicon', 'pylint'));
gulp.task('production', gulp.parallel('css', 'js', 'generate-favicon'));
gulp.task('lint', gulp.parallel('pylint'));
2 changes: 1 addition & 1 deletion gulpfile.js/tasks/pylint.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ const gulp = require('gulp');
const exec = require('child_process').exec;

let pylintTask = (cb) => {
exec('pylint packet', function (err, stdout, stderr) {
exec('pylint --load-plugins pylint_quotes packet/routes packet', function (err, stdout, stderr) {
console.log(stdout);
console.log(stderr);
cb(err);
Expand Down