Skip to content

Conversation

@MoralCode
Copy link
Contributor

quick fix for #169, although im not 100% sure if packetData.freshman_name is a full name or just a first name so I just reused the same format as

text: "You've signed " + packetData.freshman_name + "'s packet",

Copy link
Member

@devinmatte devinmatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@JoelEager JoelEager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@devinmatte devinmatte merged commit 6636bbf into ComputerScienceHouse:develop Oct 8, 2019
@MoralCode MoralCode deleted the name-confirmation branch October 8, 2019 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants