-
Notifications
You must be signed in to change notification settings - Fork 33
Packet GET routes for Conditional #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packet GET routes for Conditional #185
Conversation
devinmatte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See if that's true. And if so, use it
JoelEager
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have 1 suggestion. Other than that it looks good.
c6fb37f to
04d983d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix casing on get to GET, fix the failing pylint and then it LGTM
|
If this looks alright, I'd like to squash it before merging. |
Resolves #176