-
Notifications
You must be signed in to change notification settings - Fork 33
Phase 2: Notifications sent on Events #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
devinmatte
merged 5 commits into
ComputerScienceHouse:develop
from
devinmatte:onesignal_notifications
Aug 16, 2019
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| import onesignal | ||
|
|
||
| from packet import app, onesignal_client | ||
| from packet.models import NotificationSubscription | ||
|
|
||
| post_body = { | ||
| "content": {"en": "Default message"}, | ||
| "headings": {"en": "Default Title"}, | ||
| "included_segments": ["Active Users", "Inactive Users"], | ||
| "chrome_web_icon": app.config["PROTOCOL"] + app.config["SERVER_NAME"] + "/static/android-chrome-512x512.png", | ||
| "chrome_web_badge": app.config["PROTOCOL"] + app.config["SERVER_NAME"] + "/static/android-chrome-512x512.png", | ||
| "url": app.config["PROTOCOL"] + app.config["SERVER_NAME"] | ||
| } | ||
|
|
||
|
|
||
| def packet_signed_notification(packet, signer): | ||
| subscriptions = NotificationSubscription.query.filter_by(freshman_username=packet.freshman_username) | ||
| if subscriptions: | ||
| tokens = list(filter(lambda subscription: subscription.token, subscriptions)) | ||
|
|
||
| notification = onesignal.Notification(post_body=post_body) | ||
| notification.post_body["content"]["en"] = signer + ' signed your packet! Congrats or I\'m Sorry' | ||
| notification.post_body["headings"]["en"] = 'New Packet Signature!' | ||
| notification.post_body["chrome_web_icon"] = 'https://profiles.csh.rit.edu/image/' + signer | ||
| notification.post_body["include_player_ids"] = tokens | ||
|
|
||
| onesignal_response = onesignal_client.send_notification(notification) | ||
| if onesignal_response.status_code == 200: | ||
| app.logger.info("The notification ({}) sent out successfully".format(notification.post_body)) | ||
|
|
||
|
|
||
| def packet_100_percent_notification(packet): | ||
| subscriptions = NotificationSubscription.query.all() | ||
| if subscriptions: | ||
| tokens = list(filter(lambda subscription: subscription.token, subscriptions)) | ||
|
|
||
| notification = onesignal.Notification(post_body=post_body) | ||
| notification.post_body["content"]["en"] = packet.freshman.name + ' got 💯 on packet!' | ||
| notification.post_body["headings"]["en"] = 'New 100% on Packet!' | ||
| # TODO: Issue #156 | ||
| notification.post_body["chrome_web_icon"] = 'https://profiles.csh.rit.edu/image/' + packet.freshman_username | ||
| notification.post_body["include_player_ids"] = tokens | ||
|
|
||
| onesignal_response = onesignal_client.send_notification(notification) | ||
| if onesignal_response.status_code == 200: | ||
| app.logger.info("The notification ({}) sent out successfully".format(notification.post_body)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this need to be a thing? Couldn't we just always assume
https? Not questioning it; just curious.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When testing locally we need to use http, so it will almost always be https, but can't be guaranteed