Skip to content

Conversation

@devinmatte
Copy link
Member

A report button and form to report an issue with someone on packet to evals
report
Momomeanie

<script src="{{ url_for('static', filename='js/signing.min.js') }}"></script>
{% if info.realm == "intro" %}
<script src="{{ url_for('static', filename='js/report.min.js') }}"></script>
{% endif %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline please.

})
}
})
}); No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too.

Copy link
Collaborator

@mxmeinhold mxmeinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second the newlines that James pointed out.

@devinmatte devinmatte requested a review from mxmeinhold August 14, 2019 00:47
Copy link
Collaborator

@mxmeinhold mxmeinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢 🙌

Copy link
Collaborator

@mxmeinhold mxmeinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh I meant yeah go for it

@devinmatte devinmatte merged commit fe8ef31 into ComputerScienceHouse:develop Aug 14, 2019
@devinmatte devinmatte deleted the report branch August 14, 2019 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants