Version 3.2 #139
Merged
Version 3.2 #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust message when congratulating on Slack
I believe this resolves #43
Role Tags for Upperclassmen @devinmatte asked me to merge this in so we can get it up on develop
Correct Null error in demotion db upgrade
Update to flask-pyoidc version 2.0.0
Google Analytics through config
Bumps [lodash.merge](https://github.com/lodash/lodash) from 4.6.1 to 4.6.2. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/commits) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [lodash.mergewith](https://github.com/lodash/lodash) from 4.6.1 to 4.6.2. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/commits) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [tar](https://github.com/npm/node-tar) from 2.2.1 to 2.2.2. - [Release notes](https://github.com/npm/node-tar/releases) - [Commits](isaacs/node-tar@v2.2.1...v2.2.2) Signed-off-by: dependabot[bot] <[email protected]>
I personally don't think this is a valuable check
Style and Dependency Updates
mxmeinhold
requested changes
Aug 6, 2019
Collaborator
mxmeinhold
left a comment
mxmeinhold
left a comment
There was a problem hiding this comment.
A few smaller considerations. When I get the chance I'll glance at the web UI again and see if I can break it.
devinmatte
commented
Aug 6, 2019
mxmeinhold
reviewed
Aug 6, 2019
JoelEager
approved these changes
Aug 7, 2019
Member
JoelEager
left a comment
JoelEager
left a comment
There was a problem hiding this comment.
Overall, it looks good to me. Props to everyone who took the time to put work into this over the summer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Features: