Workaround patches #931
Merged
Workaround patches #931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettwrong
added
bug
Codecov Report
@@ Coverage Diff @@
## develop #931 +/- ##
========================================
Coverage 88.25% 88.25%
========================================
Files 119 119
Lines 10206 10206
========================================
Hits 9007 9007
Misses 1199 1199
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
garrettwrong
force-pushed
the
workaround_patches
branch
from
7d9cab6 to
165ae46
Compare
garrettwrong
force-pushed
the
workaround_patches
branch
from
165ae46 to
e64b81c
Compare
janden
approved these changes
Apr 27, 2023
Collaborator
janden
left a comment
janden
left a comment
There was a problem hiding this comment.
Looks fine, but I guess we'll discuss during our meeting today.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still isolating the memory leak issue, but the second commit here (adding cache) allows the experiments to complete without crashing due to OOM
Previously caching was not required, and I intentionally avoided it to keep the memory footprint lower on all but one of the pipelines before #902 ... Historically I would be more worried about OOM with the use of cache... so there is still something afoul, but this might allow us to move forward with the release while I continue to debug with the information I have been gathering.