Skip to content

Conversation

@garrettwrong
Copy link
Collaborator

This patches a test I recently added, but appears maybe 1% of time it will be slight outside of the 1E-8 default tolerance when run with float32. Patch uses our standard looser tolerance in this case.

I will push through to master and update the tag before the pypi release.

@garrettwrong garrettwrong added bug Something isn't working CI Continuous Integration labels Jan 6, 2023
@garrettwrong garrettwrong requested a review from j-c-c January 6, 2023 19:13
@garrettwrong garrettwrong self-assigned this Jan 6, 2023
@garrettwrong garrettwrong requested a review from janden as a code owner January 6, 2023 19:13
Copy link
Collaborator

@j-c-c j-c-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@garrettwrong garrettwrong merged commit ca76fc9 into develop Jan 6, 2023
@garrettwrong garrettwrong deleted the patch_flaky_utest branch January 6, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CI Continuous Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants