Skip to content

Conversation

@chris-langfield
Copy link
Collaborator

See #122

Code:

  • Delete old and unused crop_pad and downsample
  • Move fuzzy_mask to aspire.utils.misc
  • Delete image/preprocess.py

Tests:

  • Move fuzzy mask test to test_utils.py
  • Move hardcoded Volume projection test into "synthetic" projection test in test_volume.py
  • Delete test_preprocess.py

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #773 (c4a655d) into develop (c5a9dc7) will increase coverage by 0.51%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #773      +/-   ##
===========================================
+ Coverage    88.37%   88.89%   +0.51%     
===========================================
  Files          113      112       -1     
  Lines         8835     8760      -75     
===========================================
- Hits          7808     7787      -21     
+ Misses        1027      973      -54     
Impacted Files Coverage Δ
src/aspire/image/__init__.py 100.00% <ø> (ø)
src/aspire/utils/__init__.py 100.00% <ø> (ø)
src/aspire/utils/misc.py 92.70% <100.00%> (+1.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@garrettwrong
Copy link
Collaborator

Thanks Chris! I did a quick look and this seems fine by me, but I want to give it a closer review next week.

I'm sort of surprised we kept that dead code around so long.

@chris-langfield chris-langfield self-assigned this Nov 23, 2022
Copy link
Collaborator

@garrettwrong garrettwrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up and saving the fuzzy mask.

Copy link
Collaborator

@j-c-c j-c-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Chris!

@chris-langfield chris-langfield marked this pull request as ready for review November 28, 2022 19:26
@garrettwrong
Copy link
Collaborator

Merging. Thanks.

@garrettwrong garrettwrong merged commit 5338399 into develop Nov 29, 2022
@garrettwrong garrettwrong deleted the preprocess_122 branch November 29, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unify the functions for pre-processing 2D images and 3D volumes

4 participants