-
Notifications
You must be signed in to change notification settings - Fork 26
Cleanup preprocess.py
#773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #773 +/- ##
===========================================
+ Coverage 88.37% 88.89% +0.51%
===========================================
Files 113 112 -1
Lines 8835 8760 -75
===========================================
- Hits 7808 7787 -21
+ Misses 1027 973 -54
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks Chris! I did a quick look and this seems fine by me, but I want to give it a closer review next week. I'm sort of surprised we kept that dead code around so long. |
garrettwrong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning this up and saving the fuzzy mask.
j-c-c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, Chris!
|
Merging. Thanks. |
See #122
Code:
crop_padanddownsamplefuzzy_masktoaspire.utils.miscimage/preprocess.pyTests:
test_utils.pytest_volume.pytest_preprocess.py