Ctf regression #690
Merged
Ctf regression #690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
still not clear why pi/2 out
Codecov Report
@@ Coverage Diff @@
## develop #690 +/- ##
========================================
Coverage 87.45% 87.45%
========================================
Files 112 112
Lines 8369 8370 +1
========================================
+ Hits 7319 7320 +1
Misses 1050 1050
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
janden
approved these changes
Sep 15, 2022
| # the following parameters have higher tolerances | ||
|
|
||
| # defocusU | ||
| np.allclose( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stashing current state of ctf regression.
I'm still not clear on when the defocus angle was rotated
pi/2, and we should check what actual results are expected to be, but I've run out of time for this right now.The convex condition is an actual regression from an optimization that occurred when the unit test assert was missing.