Skip to content

Conversation

@garrettwrong
Copy link
Collaborator

Patch release. Looks like it is including more than I thought...

@garrettwrong garrettwrong self-assigned this May 27, 2022
@garrettwrong
Copy link
Collaborator Author

The version conflicts I get and are trivial to resolve, but I don't understand the others yet...

chris-langfield and others added 7 commits May 27, 2022 09:38
Fourier Bessel Mixin Class: fb.py
* dropped in new ds method

* adjust tests temporarily

* some imports

* change to centered_fft2 and allow gridpoint checks

* format

* remove debug show()

* comment

* simplify centered_fft2 and centered_ifft2
* add zenodo file with just creators

* name

* add zenodo file to manifest

* json errors

* chris orcid

* updated affiliations

* update tox.ini to include json.tool check

* josh orcid

* author ordering

* review changes
@garrettwrong
Copy link
Collaborator Author

Ahh. I think we forgot to sync develop with master after the last release.

@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #637 (6cb8831) into master (c2cd98f) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #637      +/-   ##
==========================================
- Coverage   86.52%   86.49%   -0.03%     
==========================================
  Files         108      109       +1     
  Lines        8287     8286       -1     
==========================================
- Hits         7170     7167       -3     
- Misses       1117     1119       +2     
Impacted Files Coverage Δ
src/aspire/basis/basis.py 83.92% <ø> (-3.91%) ⬇️
src/aspire/__init__.py 100.00% <100.00%> (ø)
src/aspire/apple/picking.py 91.77% <100.00%> (ø)
src/aspire/basis/__init__.py 100.00% <100.00%> (ø)
src/aspire/basis/basis_utils.py 98.17% <100.00%> (ø)
src/aspire/basis/fb.py 100.00% <100.00%> (ø)
src/aspire/basis/fb_2d.py 98.47% <100.00%> (ø)
src/aspire/basis/fb_3d.py 100.00% <100.00%> (ø)
src/aspire/basis/ffb_2d.py 100.00% <100.00%> (ø)
src/aspire/basis/ffb_3d.py 100.00% <100.00%> (ø)
... and 4 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@garrettwrong garrettwrong marked this pull request as ready for review June 1, 2022 12:28
@garrettwrong garrettwrong requested a review from janden as a code owner June 1, 2022 12:28
@garrettwrong garrettwrong requested a review from amitsinger June 2, 2022 10:49
@garrettwrong
Copy link
Collaborator Author

Hi, @chris-langfield @j-c-c , develop was rebased with master and pushed yesterday morning. That should resolve the synchronization issue discussed last week. You'll need to rebase any outstanding PRs into develop like we talked about. Most were clean rebases when I quick tested.

I think we can move forward with the patch release this week.

@garrettwrong garrettwrong merged commit 1bff8d3 into master Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants