Skip to content

Conversation

@garrettwrong
Copy link
Collaborator

Closes #589 .

Right, there we go, this should fix the whole minimal k thing.

@garrettwrong garrettwrong added bug Something isn't working cleanup labels Feb 24, 2022
@garrettwrong garrettwrong self-assigned this Feb 24, 2022
@garrettwrong garrettwrong linked an issue Feb 24, 2022 that may be closed by this pull request
@garrettwrong garrettwrong changed the title Character zero BFSReddyChetterji k Bug Feb 24, 2022
@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #590 (a2fba0b) into develop (6cb389e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #590      +/-   ##
===========================================
- Coverage    86.48%   86.48%   -0.01%     
===========================================
  Files          108      108              
  Lines         8274     8273       -1     
===========================================
- Hits          7156     7155       -1     
  Misses        1118     1118              
Impacted Files Coverage Δ
src/aspire/classification/averager2d.py 72.75% <100.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cb389e...a2fba0b. Read the comment docs.

@garrettwrong garrettwrong marked this pull request as ready for review February 24, 2022 19:56
@garrettwrong garrettwrong requested a review from janden as a code owner February 24, 2022 19:56
Copy link
Collaborator

@janden janden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (Hope you're enjoying the beach.)

@janden janden merged commit b7a3398 into develop Mar 8, 2022
@garrettwrong garrettwrong deleted the character_zero branch June 2, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Averager Alignment reflection bug

3 participants